Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding Oxygen level config option #7

Merged
merged 7 commits into from
Nov 7, 2023
Merged

Adding Oxygen level config option #7

merged 7 commits into from
Nov 7, 2023

Conversation

alberttheprince
Copy link
Contributor

@alberttheprince alberttheprince commented Nov 7, 2023 •
edited
Loading

Description

Added a config option to change the oxygen level via the config so it can be set without editing the main client file.

Checklist

  • I have personally loaded this code into an updated Qbox project and checked all of its functionality.
  • My code fits the style guidelines.
  • My PR fits the contribution guidelines.

@DevX32
Copy link

DevX32 commented Nov 7, 2023

add -- in seconds in config

@alberttheprince
Update config.lua
10faf5d
@alberttheprince
Update main.lua
3dcf31a 
replaced 100 with Config.OxygenLevel
@alberttheprince
Copy link
Contributor Author

add -- in seconds in config

done, and replaced the other instance where oxygen level ~= 100

TonybynMp4
TonybynMp4 suggested changes Nov 7, 2023
View reviewed changes
client/main.lua Outdated Show resolved Hide resolved
TonybynMp4
TonybynMp4 approved these changes Nov 7, 2023
View reviewed changes
Copy link
Contributor

@TonybynMp4 TonybynMp4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

once it's merged with the previous prs it'll be good👍🏻

@Manason Manason merged commit 9665f0c into Qbox-project:main Nov 7, 2023
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TonybynMp4 TonybynMp4 TonybynMp4 approved these changes

@Manason Manason Manason approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alberttheprince @DevX32 @Manason @TonybynMp4